Discussion:
D15641: Fix Kubrick Appdata
Aleix Pol Gonzalez
2018-09-21 09:51:54 UTC
Permalink
apol accepted this revision.
apol added a subscriber: kde-i18n-de.
apol added a comment.
This revision is now accepted and ready to land.


The german translation part should go to @kde-i18n-de. Will reach out.

REPOSITORY
R419 Kubrick

REVISION DETAIL
https://phabricator.kde.org/D15641

To: nickrichards, apol, #kde_games
Cc: kde-i18n-de, kde-games-devel
Nick Richards
2018-09-21 09:53:05 UTC
Permalink
nickrichards added a comment.


Thanks!

REPOSITORY
R419 Kubrick

REVISION DETAIL
https://phabricator.kde.org/D15641

To: nickrichards, apol, #kde_games
Cc: kde-i18n-de, kde-games-devel
Luigi Toscano
2018-09-21 10:02:37 UTC
Permalink
ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


But then the commit message should be fixed, and also the german change removed.

REPOSITORY
R419 Kubrick

REVISION DETAIL
https://phabricator.kde.org/D15641

To: nickrichards, apol, #kde_games, ltoscano
Cc: ltoscano, kde-i18n-de, kde-games-devel
Luigi Toscano
2018-09-21 10:03:02 UTC
Permalink
ltoscano added a comment.


(this specific change is going to be only about adding the oars tag)

REPOSITORY
R419 Kubrick

REVISION DETAIL
https://phabricator.kde.org/D15641

To: nickrichards, apol, #kde_games, ltoscano
Cc: ltoscano, kde-i18n-de, kde-games-devel
Nick Richards
2018-09-24 09:07:15 UTC
Permalink
nickrichards updated this revision to Diff 42221.
nickrichards retitled this revision from "Fix Kubrick Appdata" to "Add OARS to Kubrick".
nickrichards edited the summary of this revision.
nickrichards added a comment.


Removed the uncessary localization update since that has been fixed elsewhere and renamed the revision to make it clear it's just about OARS now

REPOSITORY
R419 Kubrick

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15641?vs=42042&id=42221

REVISION DETAIL
https://phabricator.kde.org/D15641

AFFECTED FILES
src/org.kde.kubrick.appdata.xml

To: nickrichards, apol, #kde_games, ltoscano
Cc: ltoscano, kde-i18n-de, kde-games-devel
Luigi Toscano
2018-09-24 09:18:05 UTC
Permalink
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


Thanks!

REPOSITORY
R419 Kubrick

REVISION DETAIL
https://phabricator.kde.org/D15641

To: nickrichards, apol, #kde_games, ltoscano
Cc: ltoscano, kde-i18n-de, kde-games-devel
Luigi Toscano
2018-10-21 14:35:23 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R419:b8e9c93836ec: Add OARS to Kubrick (authored by nickrichards, committed by ltoscano).

REPOSITORY
R419 Kubrick

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15641?vs=42221&id=44021

REVISION DETAIL
https://phabricator.kde.org/D15641

AFFECTED FILES
src/org.kde.kubrick.appdata.xml

To: nickrichards, apol, #kde_games, ltoscano
Cc: ltoscano, kde-i18n-de, kde-games-devel

Loading...