D11681: Reworked the German holiday files

[Burkhard Lück]

lueck added a subscriber: kde-i18n-de.

REPOSITORY
R175 PIM: KHolidays

REVISION DETAIL
https://phabricator.kde.org/D11681

To: tleupold, winterz
Cc: kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Tobias Leupold]

tleupold updated this revision to Diff 30508.
tleupold added a comment.


Added Nikolaus.

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11681?vs=30507&id=30508

REVISION DETAIL
https://phabricator.kde.org/D11681

AFFECTED FILES
holidays/holidays.qrc
holidays/plan2/holiday_de-bb_de
holidays/plan2/holiday_de-bw_de
holidays/plan2/holiday_de-by_de
holidays/plan2/holiday_de-hh_de
holidays/plan2/holiday_de-mv_de
holidays/plan2/holiday_de-nw_de
holidays/plan2/holiday_de-rp_de
holidays/plan2/holiday_de-sh_de
holidays/plan2/holiday_de-sl_de
holidays/plan2/holiday_de-sn_de
holidays/plan2/holiday_de-st_de
holidays/plan2/holiday_de-th_de
holidays/plan2/holiday_de_de

To: tleupold, winterz
Cc: kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Claus R.]

Seit wann ist Nikolaus ein offizieller Feiertag? Und dass da schulfrei wÀre, habe ich auch noch nicht mitbekommen. Wie wÀrs denn dann noch mit St. Martin, der heiligen Barbara, Walpurgisnacht ...

Post by Tobias Leupold
tleupold updated this revision to Diff 30508.
tleupold added a comment.
Added Nikolaus.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11681?vs=30507&id=30508
REVISION DETAIL
https://phabricator.kde.org/D11681
AFFECTED FILES
holidays/holidays.qrc
holidays/plan2/holiday_de-bb_de
holidays/plan2/holiday_de-bw_de
holidays/plan2/holiday_de-by_de
holidays/plan2/holiday_de-hh_de
holidays/plan2/holiday_de-mv_de
holidays/plan2/holiday_de-nw_de
holidays/plan2/holiday_de-rp_de
holidays/plan2/holiday_de-sh_de
holidays/plan2/holiday_de-sl_de
holidays/plan2/holiday_de-sn_de
holidays/plan2/holiday_de-st_de
holidays/plan2/holiday_de-th_de
holidays/plan2/holiday_de_de
To: tleupold, winterz
Cc: kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Allen Winter]

winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.


thanks!

REVISION DETAIL
https://phabricator.kde.org/D11681

To: tleupold, winterz
Cc: kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Tobias Leupold]

tleupold added a comment.


Thanks for the quick review! Does this now automagically go to git? Or should I push it? Sorry for asking dumbn questions, but I'm pretty new to that Phabricator widget ;-)

REVISION DETAIL
https://phabricator.kde.org/D11681

To: tleupold, winterz
Cc: kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Allen Winter]

winterz added a comment.


you can push directly.
then close this phab and also close the bugs you opened regarding this problem

REVISION DETAIL
https://phabricator.kde.org/D11681

To: tleupold, winterz
Cc: kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Luigi Toscano]

ltoscano added a comment.


Please push it with arc land, which is strongly suggested way: phabricator will parse the commit message and close this review.

REVISION DETAIL
https://phabricator.kde.org/D11681

To: tleupold, winterz
Cc: ltoscano, kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Luigi Toscano]

ltoscano added a comment.


Also, does this review fixes https://bugs.kde.org/show_bug.cgi?id=373686 ? If yes, please edit the commit message from phabricator adding a *separate* line

BUG: nnnnnn

and that will make sure that the bug nnnnnn is closed.

REVISION DETAIL
https://phabricator.kde.org/D11681

To: tleupold, winterz
Cc: ltoscano, kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil

[Tobias Leupold]

tleupold closed this revision.
tleupold added a comment.


Sorry, apparently, Arcanoid is currently not available yet on Gentoo (at least in the main Portage tree). So I did it manually. I added the bug so that it will be closed automatically though (at least I hope so ;-). Thanks for the support and the quick replies!

REVISION DETAIL
https://phabricator.kde.org/D11681

To: tleupold, winterz
Cc: ltoscano, kde-i18n-de, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil